API: add float128 and float32(64,128)_complex dt#492
Merged
vspetrov merged 4 commits intoopenucx:masterfrom Jun 21, 2022
Merged
API: add float128 and float32(64,128)_complex dt#492vspetrov merged 4 commits intoopenucx:masterfrom
vspetrov merged 4 commits intoopenucx:masterfrom
Conversation
samnordmann
changed the title
samnordmann
force-pushed
the
complex_dt
branch
2 times, most recently
from
128cba3 to
80f7bd6
Compare
Contributor
|
@samnordmann It might be better to decouple the formatting changes from the functional changes. |
shimmybalsam
reviewed
May 2, 2022
jladd-mlnx
suggested changes
May 5, 2022
jladd-mlnx
left a comment
jladd-mlnx
left a comment
There was a problem hiding this comment.
-
Way too many white-space changes. I had to hide whitespaces in order to make sense of the PR.
-
The file
src/ucc/api/ucc.his Whitespace-only changes. -
Should we include support for complex half precision? Does HPL AI use it?
typedef enum cudaDataType_t
{
CUDA_R_16F= 2, // 16 bit real
CUDA_C_16F= 6, // 16 bit complex
CUDA_R_32F= 0, // 32 bit real
CUDA_C_32F= 4, // 32 bit complex
CUDA_R_64F= 1, // 64 bit real
CUDA_C_64F= 5, // 64 bit complex
CUDA_R_8I= 3, // 8 bit real as a signed integer
CUDA_C_8I= 7, // 8 bit complex as a pair of signed integers
CUDA_R_8U= 8, // 8 bit real as a signed integer
CUDA_C_8U= 9 // 8 bit complex as a pair of signed integers
} cudaDataType;
Merged
samnordmann
force-pushed
the
complex_dt
branch
3 times, most recently
from
8b42a71 to
20d60a8
Compare
Collaborator
Author
The formatting changes were due to a mistake with automatic formatting. It is fixed now. |
samnordmann
force-pushed
the
complex_dt
branch
2 times, most recently
from
cd992f2 to
9bed721
Compare
shimmybalsam
approved these changes
May 9, 2022
samnordmann
force-pushed
the
complex_dt
branch
5 times, most recently
from
db2ae78 to
3a5f501
Compare
Contributor
There was a problem hiding this comment.
not related to this PR, but there are SHARP_DTYPE_UINT8 and SHARP_DTYPE_UINT8 defined in sharp.h, should we update mapping? cc @bureddy
vspetrov
reviewed
Jun 14, 2022
samnordmann
force-pushed
the
complex_dt
branch
2 times, most recently
from
6ee4591 to
4b54615
Compare
Collaborator
|
bot:retest |
samnordmann
force-pushed
the
complex_dt
branch
5 times, most recently
from
2cb6da8 to
50ae438
Compare
vspetrov
approved these changes
Jun 20, 2022
Collaborator
vspetrov
left a comment
vspetrov
left a comment
There was a problem hiding this comment.
@samnordmann plz address final set of minor changes
Sergei-Lebedev
approved these changes
Jun 21, 2022
Sergei-Lebedev
pushed a commit
to Sergei-Lebedev/ucc
that referenced
this pull request
Jun 22, 2022
* API: add float128 and float32(64,128)_complex dt * TEST: update mpi_tests with new dt * TEST: update Gtest with new dt * BUILD: check dt size during preprocessing
kingchc
pushed a commit
to facebookresearch/ucc
that referenced
this pull request
Jul 20, 2022
* API: add float128 and float32(64,128)_complex dt * TEST: update mpi_tests with new dt * TEST: update Gtest with new dt * BUILD: check dt size during preprocessing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add support for four new datatypes: float128, float32_complex, float64_complex, float128_complex.